Re: [PATCH] sysrq: showBlockedTasks is sysrq-X

[Randy Dunlap <rdunlap@xenotime.net>]

On Fri, 5 Jan 2007 20:36:05 +0100 Olaf Hering wrote:

> On Fri, Jan 05, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > SysRq showBlockedTasks is not done via B or T, it's done via X,
> > so put that in the Help message.
> 
> Weird, who failed to run this command before adding new stuff?!
> find * -type f -print0 | xargs -0 env -i grep -nw register_sysrq_key
> 
> sysrq x is for xmon, see arch/powerpc/xmon/xmon.c
> Better switch the new stuff to 'z' or 'w'
> -

OK.  There is also a collision on 'c':

drivers/net/ibm_emac/ibm_emac_debug.c:195:
    return register_sysrq_key('c', &emac_sysrq_op)

and sysrq_crashdump_op.  I'd say ibm_emac needs to change too.

I'll resend.
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/