Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

[Jeff Garzik <jeff@garzik.org>]

Jeff Garzik wrote:
> * After your patch, the code explicitly calls pci_request_region() for 
> BARs 0-4, but never for BAR5.

Without checking for failures, I might add.

Let's call that regression/obvious bug #4, because the previous code 
actually CARED if the resource was reserved.

>                 if (legacy_mode & ATA_PORT_PRIMARY)
>                         pci_request_region(pdev, 1, DRV_NAME);
>                 if (legacy_mode & ATA_PORT_SECONDARY)
>                         pci_request_region(pdev, 3, DRV_NAME);
>                 /* If there is a DMA resource, allocate it */
>                 pci_request_region(pdev, 4, DRV_NAME);

I agree this is one way to avoid conflicts!  ;-)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/