Re: tty->low_latency + irq context

[Hollis Blanchard <hollisb@us.ibm.com>]

On Tue, 2007-01-02 at 18:38 +0000, Alan wrote:
> > with tty->low_latency set, but it doesn't AFAICS. One possibility
> for
> > deadlock is if the tty->buf.lock spinlock is taken on behalf of a
> user
> > process...
> 
> The case to watch out for is
> 
>         flip_buffer_push -> ldisc -> driver write of echo/^S/^Q
> 
> if you call flip_buffer_push while holding your own lock you may get
> in a mess on the echo path. 

Agreed. However, that's not what the comment says:

 *      tty_flip_buffer_push    -       terminal
 *      @tty: tty to push
 *
 *      Queue a push of the terminal flip buffers to the line discipline. This
 *      function must not be called from IRQ context if tty->low_latency is set.

-- 
Hollis Blanchard
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/