> * I was unable to argue against Alan's logic behind
> 368c73d4f689dae0807d0a2aa74c61fd2b9b075f but I just don't like it.
> Regardless of whether or not this truly reflects how the PCI device is
> wired, it makes pci_request_regions() and similar resource handling code
> behave differently.
Correctly: The resource tree is no longer corrupt for example and
pci_* resource functions actually now do the right thing. The old code
works by chance due to link order, not because anything was "broken" by
the corrections.
> * Alan proposed a libata fix patch. I noted two key breakages in his
> fix patch, one of which Alan agreed was a problem.
Not a "2.6.20 stopping problem" and trivial to fix further.
> So I vote for revert, for 2.6.20, but I know Alan will squawk loudly.
> Also NOTE thoughfb0f2b40faff41f03acaa2ee6e6231fc96ca497c which fixes
> fallout from Alan's change, too.
I'm very concerned about what that will break that depends upon it - eg
all the work done for suspend/resume PCI handling has not been tested
without the patch. Thus I'd rather fix it given the fix is trivial.
Want a fix Linus given Jeff is away ?
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]