Re: [PATCH] net/core/flow.c: compare data with memcmp

From: "Daniel_Marjamäki" <[email protected]>
Date: Sun, 31 Dec 2006 17:37:05 +0100

> From: Daniel Marjamäki
> This has been tested by me.
> Signed-off-by: Daniel Marjamäki <[email protected]>

Please do not do this.

memcmp() cannot assume the alignment of the source and
destination buffers and thus will run more slowly than
that open-coded comparison.

That code was done like that on purpose because it is
one of the most critical paths in the networking flow
cache lookup which runs for every IPSEC packet going
throught the system.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] net/core/flow.c: compare data with memcmp
  - From: "Daniel Marjamäki" <[email protected]>

Prev by Date: Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.
Next by Date: Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again
Previous by thread: Re: [KJ] [PATCH] net/core/flow.c: compare data with memcmp
Next by thread: [KVM][PATCH] smp_processor_id() and sleeping functions used in invalid context
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]