Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 29 December 2006 7:15 pm, Nicolas Pitre wrote:
> On Fri, 29 Dec 2006, David Brownell wrote:
> 
> > Here's a version that compiles ...
> 
> This patch is completely broken.

It's just what Philipp sent, with the "won't compile" bugs fixed.
Oh, and some #include tweaks.  Philipp?


> > Arch-neutral GPIO calls for PXA.
> 
> This is not PXA but SA1100 to start with.

I seem to have copied the wrong header comment, sorry; the original
patch had none.  It's marginally better than the header claiming it
was a PXA header...


> and you most probably need to protect the implied read-modify-write 
> cycle with a spinlock unless the generic gpio API expects this 
> protection is the responsibility of the caller.

No such lock is known to the caller.  Some of those calls will need
to move to a C file somewhere.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux