Re: [FSAIO][PATCH 7/8] Filesystem AIO read

On Dec 28 2006 11:57, Christoph Hellwig wrote:
>
>> +
>> +		if ((error = __lock_page(page, current->io_wait))) {
>> +			goto readpage_error;
>> +		}
>
>This should  be
>
>		error = __lock_page(page, current->io_wait);
>		if (error)
>			goto readpage_error;

That's effectively the same. Essentially a style thing, and I see if((err =
xyz)) not being uncommon in the kernel tree.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [FSAIO][PATCH 7/8] Filesystem AIO read
    • From: Randy Dunlap <[email protected]>

• References:
  • [RFC] Heads up on a series of AIO patchsets
    • From: Suparna Bhattacharya <[email protected]>
  • [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write
    • From: Suparna Bhattacharya <[email protected]>
  • [FSAIO][PATCH 7/8] Filesystem AIO read
    • From: Suparna Bhattacharya <[email protected]>
  • Re: [FSAIO][PATCH 7/8] Filesystem AIO read
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: The Input Layer and the Serial Port
• Next by Date: Re: Finding hardlinks
• Previous by thread: Re: [FSAIO][PATCH 7/8] Filesystem AIO read
• Next by thread: Re: [FSAIO][PATCH 7/8] Filesystem AIO read
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]