Re: [patch] net/xfrm: fix crash in ipsec audit logging

[jamal <hadi@cyberus.ca>]

On Tue, 2006-26-12 at 18:56 +0100, Ingo Molnar wrote:


> +	xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
> +		       AUDIT_MAC_IPSEC_DELSPD, delete, xp, NULL);
> +
>  	if (!delete) {
>  		struct sk_buff *resp_skb;


You could move the call into the else from above if (!delete) maybe?
Otherwise you have to add back the "if (delete)" check since that
function could be used to either retrieve (which is not subject to an
audit) or delete an xp.

cheers,
jamal
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/