Re: [PATCH] Update Documentation/pci.txt v7

[Grant Grundler <grundler@parisc-linux.org>]

On Sun, Dec 24, 2006 at 11:16:22AM -0800, Randy Dunlap wrote:
> On Sat, 23 Dec 2006 23:07:26 -0700 Grant Grundler wrote:
> 
> > +10. Legacy I/O port free driver
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> That subject (and patches with similar subject) confuses me.
> It's difficult to associate the adjectives correctly.

Agreed. This was the original section name and I didn't
have a better idea.

> I suppose it just needs some hyphens/dashes, like:
> 
> 10. Legacy-I/O-port-free driver
> 
> but that's ETOOMUCH.  Maybe ?
> 
> 10.  Stop using legacy I/O space

Yeah, that is good too.

I changed it to "10. pci_enable_device_bars() and Legacy I/O Port space".
The goal of this section is to introduce the new PCI function 
and why one should use it.


...
> > +Thus, timing sensitive code should add readl() where the CPU is
> > +expected to wait before doing other work.  The classic "bit banging"
> > +sequence works fine for I/O Port space:
> > +
> > +       for (i=8; --i; val >>= 1) {
> 
> Please use:	i = 8;
> to match CodingStyle.  (and below)

Definitely....Sorry, I thought someone already asked me to change this.
I thought I did. Changed now in both cases.


> Rest looks good to me.

v8 will be posted shortly.

thanks Randy!
grant
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/