Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 22 Dec 2006, pHilipp Zabel wrote:

> On 12/21/06, Andrew Morton <[email protected]> wrote:
> > On Wed, 20 Dec 2006 13:13:21 -0800
> > David Brownell <[email protected]> wrote:
> >
> > > +#define gpio_get_value(gpio) \
> > > +     (GPLR & GPIO_GPIO(gpio))
> > > +
> > > +#define gpio_set_value(gpio,value) \
> > > +     ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gpio) =
> > > GPIO_GPIO(gpio)))
> >
> > likewise.
> 
> I have done the same to the SA1100 wrappers as to the PXA wrappers now.
> Maybe the non-inline functions in generic.c are overkill for those much
> simpler
> macros on SA...

I think the SA1x00 has no advantage of having out of line versions.  The 
function call will cost more than the inline version even if gpio is not 
constant.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux