Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

On Fri, 22 Dec 2006, Christoph Hellwig wrote:

> On Wed, Dec 20, 2006 at 04:46:51PM -0800, Andrew Morton wrote:
> > On Sun, 17 Dec 2006 07:43:39 -0500 (EST)
> > "Robert P. J. Day" <[email protected]> wrote:
> >
> > >   as with ARRAY_SIZE(), there are a number of places (mercifully, far
> > > fewer) that recode what could be done with the FIELD_SIZEOF() macro in
> > > kernel.h.
>
> Who introduced FIELD_SIZEOF?  The name is the wrong way around, it
> should either be SIZEOF_FIELD if you want the SIZEOF part of
> FIELD_SIZE if you want to follow the ARRAY_SIZE example/

that's the name as it *already* existed in kernel.h.  however, since
no one was actually using it yet, it's a piece of cake to give it a
better name.  either FIELD_SIZE or MEMBER_SIZE would work just fine.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
    • From: Jan Engelhardt <[email protected]>

• References:
  • [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
    • From: "Robert P. J. Day" <[email protected]>
  • Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
    • From: Andrew Morton <[email protected]>
  • Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined!
• Next by Date: [PATCH 5/6] containers: Resource Groups over generic containers
• Previous by thread: Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
• Next by thread: Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]