Re: [PATCH 2/10] cxgb3 - main source file

[Divy Le Ray <divy@chelsio.com>]

Arjan van de Ven wrote:
> > They are used to parameter the HW:
> > register access,
>
> ethtool supports that, so shouldn't be an ioctl for sure
>
> >  configuration of queue sets, on board memory 
> > configuration,
>
> I'm sure ethtool can do that too
>
> > firmware load, etc ...
>
> and for this we have request_firmware() interface. 
>
> adding device specific ioctl that duplicate functionality that exists or
> should exist in a generic way isn't really acceptable for 2.6 kernels
> anymore....
Arjan,

The driver implements all the ethtool operations that apply to it.
The GETREG ioctl is left for debug purposes:
get_regs doesn't return clear-on-read registers while GETREG does.

Using request_firmware assumes that the driver knows the FW file name
and the driver initiates the load. That's not our model where we work
with different FWs, don't know what the names are, and the user 
initiates the load.

Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/