Re: [PATCH 2/10] cxgb3 - main source file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Arjan van de Ven wrote:
They are used to parameter the HW:
register access,

ethtool supports that, so shouldn't be an ioctl for sure

configuration of queue sets, on board memory configuration,

I'm sure ethtool can do that too

firmware load, etc ...

and for this we have request_firmware() interface.
adding device specific ioctl that duplicate functionality that exists or
should exist in a generic way isn't really acceptable for 2.6 kernels
anymore....

Arjan,

The driver implements all the ethtool operations that apply to it.
The GETREG ioctl is left for debug purposes:
get_regs doesn't return clear-on-read registers while GETREG does.

Using request_firmware assumes that the driver knows the FW file name
and the driver initiates the load. That's not our model where we work
with different FWs, don't know what the names are, and the user initiates the load.

Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux