Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()

+	if (len > TASK_SIZE)
+		return -ENOMEM;

Shouldn't that be addr+len instead?  The check looks incomplete
otherwise.  And you meant ">=" I guess?

-		/* Paranoia, caller should have dealt with this */
-		BUG_ON((addr + len) > 0x100000000UL);
-

Any real reason to remove the paranoia check?  If it's trivially
always satisfied, the compiler will get rid of it for you :-)

Cheers,


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()
    • From: David Gibson <[email protected]>

• References:
  • [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()
    • From: David Gibson <[email protected]>

• Prev by Date: v2.6.20-rc1-rt3, yum/rpm
• Next by Date: Re: Binary Drivers
• Previous by thread: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()
• Next by thread: Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]