Re: [PATCH 1/2] Fix /sys/device/.../power/state

[David Brownell <david-b@pacbell.net>]

On Wednesday 20 December 2006 8:06 pm, Matthew Garrett wrote:
> On Wed, Dec 20, 2006 at 07:04:28PM -0800, David Brownell wrote:
> > On Wednesday 20 December 2006 5:29 pm, Matthew Garrett wrote:
> > > I dislike that.
> > 
> > Tough noogies, as they say.  In a tradeoff between correctness and your
> > personal taste (or even mine, sigh!), the normal tradeoff is in favor
> > of correctness.
> 
> But it's not correct - the test prohibits suspending devices even if 
> it would be safe to do so.

It prohibits suspending them unless it's known to be safe.  What your
patch does is add some more ways to know it's safe.  My comment was
that while adding ways is safe, it's incorrect to allow things which
aren't known to be safe.


> > > We're asking to suspend an individual device - whether  
> > > the bus supports devices that need to suspend with interrupts disabled 
> > > is irrelevent, it's the device that we care about. We should just make 
> > > it necessary for every bus to support this method until the interface is 
> > > removed.
> > 
> > But you _didn't_ do anything to "make it necessary".  Which means that
> > your patch *WILL* cause bugs whenever a driver uses those calls, and
> > courtesy of your patch userspace tries to suspend that device ... 
> 
> New patch attached.

I'll have a look at it after I get past some other stuff.  I take it that
you tested this by now?  I assume it'd work, but you know how that goes.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/