Re: [patch] x86_64: fix boot hang caused by CALGARY_IOMMU_ENABLED_BY_DEFAULT

[Muli Ben-Yehuda <muli@il.ibm.com>]

On Wed, Dec 20, 2006 at 11:28:46AM +0100, Ingo Molnar wrote:

>  config CALGARY_IOMMU_ENABLED_BY_DEFAULT
>         bool "Should Calgary be enabled by default?"
>         default y
>         depends on CALGARY_IOMMU
>         help
>           Should Calgary be enabled by default? if you choose 'y', Calgary
>           will be used (if it exists). If you choose 'n', Calgary will not be
>           used even if it exists. If you choose 'n' and would like to use
>           Calgary anyway, pass 'iommu=calgary' on the kernel command line.
>           If unsure, say Y.
> 
> it's both 'default y', and says "If unsure, say Y". Clearly not a
> typo.

I think that it makes sense to have it default y for the mainline
kernel and default n for the distro kernels, which is why I added the
option to make it possible to compile Calgary in but only enable it if
you want to use it. Previously if you compiled it in it would be used,
period. You may disagree, but fundamentally I think the mainline
kernel should be fairly experimental, which means enabling new code by
default.

As to what actually happened, I'm betting your machine has both
Calgary and CalIOC2, the PCI-e version of Calgary, which is not yet
supported by pci-calgary.c. I have a patch for CalIOC2 which is work
in progress and not ready for inclusion yet. Can you please send lspci
-v to confirm?

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/