Re: [PATCH 3/4] Add driver for OHCI firewire host controllers.

[Robert Hancock <hancockr@shaw.ca>]

Kristian Høgsberg wrote:
> Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
> ---
>  drivers/firewire/Kconfig   |   11 
>  drivers/firewire/Makefile  |    1 
>  drivers/firewire/fw-ohci.c | 1394 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/firewire/fw-ohci.h |  152 +++++
>  4 files changed, 1558 insertions(+), 0 deletions(-)

..

> +static struct pci_driver fw_ohci_pci_driver = {
> +	.name		= ohci_driver_name,
> +	.id_table	= pci_table,
> +	.probe		= pci_probe,
> +	.remove		= pci_remove,
> +};

How about suspend/resume support? Lots of laptops have OHCI 1394 and 
full suspend/resume support is something that the current ohci1394 
driver lacks.

--
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/