Am 19.12.2006 20:56 schrieb Ingo Molnar: > thanks for the report - this made me review the hrtimer state engine > logic, and bingo, it indeed has a nasty typo! Could you try the fix > below, does it fix your problem? It might explain the crash you are > seeing, because the typo means we'd ignore HRTIMER_STATE_PENDING state > (which is rare but possible). Ok, the machine has been running for a couple of hours with that patch and so far hasn't frozen again. I'll watch it some more but it looks like your patch did indeed fix my problem. Thanks Tilman > --------------------------> > Subject: [patch] hrtimers: add state tracking, fix > From: Ingo Molnar <[email protected]> > > fix bug in hrtimer_is_queued(), introduced by a cleanup during > the recent refactoring. > > Signed-off-by: Ingo Molnar <[email protected]> > --- > kernel/hrtimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/kernel/hrtimer.c > =================================================================== > --- linux.orig/kernel/hrtimer.c > +++ linux/kernel/hrtimer.c > @@ -157,7 +157,7 @@ static void hrtimer_get_softirq_time(str > static inline int hrtimer_is_queued(struct hrtimer *timer) > { > return timer->state & > - (HRTIMER_STATE_ENQUEUED || HRTIMER_STATE_PENDING); > + (HRTIMER_STATE_ENQUEUED | HRTIMER_STATE_PENDING); > } > > /* -- Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Attachment:
signature.asc
Description: OpenPGP digital signature
- References:
- 2.6.20-rc1-mm1
- From: Andrew Morton <[email protected]>
- BUG: NMI Watchdog detected LOCKUP (was: 2.6.20-rc1-mm1)
- From: Tilman Schmidt <[email protected]>
- [patch] hrtimers: add state tracking, fix
- From: Ingo Molnar <[email protected]>
- 2.6.20-rc1-mm1
- Prev by Date: Re: [Bug 7505] Linux-2.6.18 fails to boot on AMD64 machine
- Next by Date: [patch 1/4] Add <linux/klog.h>
- Previous by thread: [patch] hrtimers: add state tracking, fix
- Next by thread: Re: [patch] hrtimers: add state tracking, fix
- Index(es):
 |