On Tue, 19 Dec 2006, Andrei Popa wrote:
> >
> > There's exactly two call sites that call "page_mkclean()" (an dthat is the
> > only thing in turn that calls "page_mkclean_one()", which we already
> > determined will cause the corruption).
> >
> > Can you just TOTALLY DISABLE that case for the test_clear_page_dirty()
> > case? Just do an "#if 0 .. #endif" around that whole if-statement, leaving
> > the _only_ thing that actually calls "page_mkclean()" to be the
> > "clear_page_dirty_for_io()" call.
> >
> > Do you still see corruption?
>
> nope, no file corruption at all.
Ok. That's interesting, but I think you actually #ifdef'ed out too
much:
> +
> +#if 0
> if (TestClearPageDirty(page)) {
> radix_tree_tag_clear(&mapping->page_tree,
> page_index(page), PAGECACHE_TAG_DIRTY);
> @@ -866,11 +868,19 @@ int test_clear_page_dirty(struct page *p
> * page is locked, which pins the address_space
> */
> if (mapping_cap_account_dirty(mapping)) {
> - page_mkclean(page);
> + int cleaned = page_mkclean(page);
> + if (!must_clean_ptes && cleaned){
> + WARN_ON(1);
> + set_page_dirty(page);
> + }
> +
> dec_zone_page_state(page, NR_FILE_DIRTY);
> }
> return 1;
> }
> +
> +#endif
> +
It was really just the _inner_ "if (mapping_cap_account_dirty(.."
statement that I meant you should remove.
Can you try that too?
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
