[2.6 patch] drivers/media/video/cafe_ccic.c: fix NULL dereference

We shouldn't dereference "cam" when we already know it's NULL.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.20-rc1-mm1/drivers/media/video/cafe_ccic.c.old	2006-12-18 01:14:24.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/media/video/cafe_ccic.c	2006-12-18 01:21:29.000000000 +0100
@@ -2166,7 +2166,7 @@ static void cafe_pci_remove(struct pci_d
 	struct cafe_camera *cam = cafe_find_by_pdev(pdev);
 
 	if (cam == NULL) {
-		cam_warn(cam, "pci_remove on unknown pdev %p\n", pdev);
+		printk(KERN_WARNING "pci_remove on unknown pdev %p\n", pdev);
 		return;
 	}
 	mutex_lock(&cam->s_mutex);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: 2.6.19 (current from git) on SPARC64: Can't mount /
• Next by Date: [2.6 patch] drivers/isdn/hisax/: proper prototypes
• Previous by thread: BUG on 2.6.20-rc1 when using gdb
• Next by thread: [2.6 patch] drivers/isdn/hisax/: proper prototypes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]