Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

[Ingo Oeser <ioe-lkml@rameria.de>]

On Tuesday, 12. December 2006 18:34, Pekka Enberg wrote:
> On 12/12/06, Yan Burman <burman.yan@gmail.com> wrote:
> >         size = txdr->count * sizeof(struct e1000_buffer);
> > -       if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
> > +       if (!(txdr->buffer_info = kzalloc(size, GFP_KERNEL))) {
> >                 ret_val = 1;
> >                 goto err_nomem;
> >         }
> > -       memset(txdr->buffer_info, 0, size);
> 
> No one seems to be using size elsewhere so why not convert to
> kcalloc() and get rid of it? (Seems to apply to other places as well.)

Because if done properly that often exceeds the 80 column limit.
The intermediate variable should be optimized away from the compiler.

But kcalloc() is better for another reason: Overflow checking.

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/