Re: [PATCH/v2] CodingStyle updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/15/06, Pavel Machek <[email protected]> wrote:
Hi!

> Pavel Machek wrote:
> >> From: Randy Dunlap <[email protected]>
> >> +Use one space around (on each side of) most binary and ternary operators,
> >> +such as any of these:
> >> +  =  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
> >
> > Actually, this should not be hard rule. We want to allow
> >
> >     j = 3*i + l<<2;
>
> Which would be very misleading. This expression evaluates to
>
>       j = (((3 * i) + l) << 2);
>
> Binary + precedes <<.

Aha, okay. So this one should be written as

        j = 3*i+l << 2;

(Well, parenthesses should really be used. Anyway, sometimes grouping
around operator is useful, even if I made mistake demonstrating that.
---

I think the mistake illuminates why parentheses should be the rule. If
you're thinking about using spacing to convey grouping, use
parentheses instead...

scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux