On Thu, 14 Dec 2006 16:16:40 -0800 Zack Weinberg wrote:
> This patch introduces <linux/klog.h> with symbolic constants for the
> various sys_syslog() opcodes, and changes all in-kernel references to
> those opcodes to use the constants. The header is added to the set of
> user/kernel interface headers. (Unlike the previous revision of this
> patch series, no kernel-private additions to this file are contemplated.)
Hi Zack,
This patch looks good except for one nit:
> --- linux-2.6.orig/fs/proc/kmsg.c 2006-12-13 15:53:29.000000000 -0800
> +++ linux-2.6/fs/proc/kmsg.c 2006-12-13 16:04:46.000000000 -0800
> @@ -21,27 +22,28 @@
>
> static int kmsg_open(struct inode * inode, struct file * file)
> {
> - return do_syslog(1,NULL,0);
> + return do_syslog(KLOG_OPEN,NULL,0);
> }
>
> static int kmsg_release(struct inode * inode, struct file * file)
> {
> - (void) do_syslog(0,NULL,0);
> + (void) do_syslog(KLOG_CLOSE,NULL,0);
> return 0;
> }
Please use a space after the commas (even though you just left it
as it already was).
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
