Re: lots of code could be simplified by using ARRAY_SIZE()

On Fri, 15 Dec 2006, Miguel Ojeda wrote:

> On 12/13/06, Robert P. J. Day <[email protected]> wrote:
> >
> >   there are numerous places throughout the source tree that apparently
> > calculate the size of an array using the construct
> > "sizeof(fubar)/sizeof(fubar[0])". see for yourself:
> >
> >   $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" *
> >
> > but we already have, from "include/linux/kernel.h":
> >
> >   #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
>
> Maybe *(x) instead of (x)[0]?

yeah, there's a bunch of that, too:

  $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\*\1\)" .

easy enough to catch using the same technique.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • lots of code could be simplified by using ARRAY_SIZE()
    • From: "Robert P. J. Day" <[email protected]>
  • Re: lots of code could be simplified by using ARRAY_SIZE()
    • From: "Miguel Ojeda" <[email protected]>

• Prev by Date: [PATCH] [AGP] Fix detection of aperture size versus GTT size on G965.
• Next by Date: Register process keyrings task watcher
• Previous by thread: Re: lots of code could be simplified by using ARRAY_SIZE()
• Next by thread: Re: lots of code could be simplified by using ARRAY_SIZE()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]