Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core

> +void edac_mc_handle_fbd_ue(struct mem_ctl_info *mci,
> +				unsigned int csrow,
> +				unsigned int channela,
> +				unsigned int channelb,
> +				char *msg)
> +{
> +	int len = EDAC_MC_LABEL_LEN * 4;
> +	char labels[len + 1];

Have you checked gcc generates the right code from this and not a dynamic
allocation. I'm not sure if you want "const int len" to force that ?


Otherwise looks ok
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
    • From: Doug Thompson <[email protected]>
  • Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
    • From: Doug Thompson <[email protected]>

• Prev by Date: Re: Userspace I/O driver core
• Next by Date: Re: Userspace I/O driver core
• Previous by thread: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
• Next by thread: Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]