Re: [RFC] new MSR r/w functions per CPU

Dave Jones wrote:

Exposing the guts of the msr driver like that doesn't seem too clean.
For in-kernel use, why not just add something like this..
(note:not even compile tested)..

Well, that *is* the guts of the MSR driver.

void rdmsr_on_cpu(unsigned int cpu, unsigned long msr, unsigned long *lo, unsigned long *hi)
{
    cpumask_t oldmask;

    oldmask = current->cpus_allowed;
    set_cpus_allowed(current, cpumask_of_cpu(cpu));

	rdmsr(msr, &lo, &hi);

    set_cpus_allowed(current, oldmask);
}

[The above doesn't work, by the way. This approach was discussed a long time ago, and vetoed due to the potential for deadlock.]

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC] new MSR r/w functions per CPU
    • From: Dave Jones <[email protected]>

• References:
  • [RFC] new MSR r/w functions per CPU
    • From: Rudolf Marek <[email protected]>
  • Re: [RFC] new MSR r/w functions per CPU
    • From: Dave Jones <[email protected]>

• Prev by Date: [PATCH 1/1] Char: tty, delete wake_up_interruptible after tty_wakeup
• Next by Date: 2.6.18.3, sata dvd writer: can't watch dvd
• Previous by thread: Re: [RFC] new MSR r/w functions per CPU
• Next by thread: Re: [RFC] new MSR r/w functions per CPU
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]