On Tue, 12 Dec 2006 17:17:56 -0800 (PST)
David Miller <[email protected]> wrote:
> From: Adrian Bunk <[email protected]>
> Date: Tue, 12 Dec 2006 17:24:35 +0100
>
> > This patch converts drivers/net/loopback.c to using module_init().
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
>
> I'm not %100 sure of this one, let's look at the comment you
> are deleting:
>
> > -/*
> > - * The loopback device is global so it can be directly referenced
> > - * by the network code. Also, it must be first on device list.
> > - */
> > -extern int loopback_init(void);
> > -
>
> in particular notice the part that says "it must be first on the
> device list".
>
> I'm not sure whether that is important any longer. It probably isn't,
> but we should verify it before applying such a patch.
>
> Since module_init() effectively == device_initcall() for statically
> built objects, which loopback always is, the Makefile ordering does
> not seem to indicate to me that there is anything guarenteeing
> this "first on the list" invariant. At least not via object
> file ordering.
>
> So this gives some support to the idea that loopback_dev's position
> on the device list no longer matters.
The dst code makes assumptions that loopback is ifindex 1 as well.
NAK on Adrian's change, it doesn't buy anything
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
