Re: [Linux-fbdev-devel] [PATCH] Proper backlight selection for fbdev drivers

[James Simmons <jsimmons@infradead.org>]

The problem is the overlap of the patches 

fbdev-update-after-backlight-argument-change.diff
proper-backlight-selection-forfbdev-drivers.patch

The machine_is change is in the argument change patch. It should be in 
this patch. I can send updates of both patches.

On Wed, 13 Dec 2006, Andrew Morton wrote:

> On Thu, 7 Dec 2006 17:59:01 +0000 (GMT)
> James Simmons <jsimmons@infradead.org> wrote:
> 
> > Try this patch. This should fix any module/built-in dependencys.
> 
> drivers/video/aty/atyfb_base.c: In function 'atyfb_blank':
> drivers/video/aty/atyfb_base.c:2817: warning: implicit declaration of function 'machine_is'
> drivers/video/aty/atyfb_base.c:2817: error: 'powermac' undeclared (first use in this function)
> drivers/video/aty/atyfb_base.c:2817: error: (Each undeclared identifier is reported only once
> drivers/video/aty/atyfb_base.c:2817: error: for each function it appears in.)
> 
> This is i386 build.
> 
> #ifdef CONFIG_FB_ATY_BACKLIGHT
> 	if (machine_is(powermac) && blank > FB_BLANK_NORMAL)
> 		aty_bl_set_power(info, FB_BLANK_POWERDOWN);
> #elif defined(CONFIG_FB_ATY_GENERIC_LCD)
> 
> It assumes that only pmacs have backlights.
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/