Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >>+static int tc86c001_busproc(ide_drive_t *drive, int state)
> >>+{
> 
> > Waste of space having a busproc routine. The maintainer removed all the
> > usable hotplug support from old IDE so this might as well be dropped.
> 
>     Don't know what you mean, ioctl is still there...

You can turn the bus on and off but there is no ability to actually swap
drives except in RHEL4 and 2.4.x-ac kernels. Hence "waste of space"

> > "Close but no cookie": please fix the PCI quirk to match the current -mm
> > behaviour with the ATA resource tree. Otherwise - nice driver.
> 
>     Ugh, I should've expected some backstab from -mm tree...

If it is native only then there are no problems with the quirk 

Acked-by: Alan Cox <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux