Re: [PATCH] Add the ability to layer another driver over the serial driver

Alan wrote:

On Sun, 10 Dec 2006 19:23:54 -0600
Corey Minyard <[email protected]> wrote:

Nothing has come of this yet. But we have these two requests and a request from Russell Doty at Redhat.

It would be nice to know if this type of thing was acceptable or not, and the problems with the patch. The patch is at http://home.comcast.net/~minyard

This looks wrong. You already have a kernel interface to serial drivers.
It is called a line discipline. We use it for ppp, we use it for slip, we
use it for a few other things such as attaching sync drivers to some
devices.

Discussions of the form  "my line discipline has no way to do 'xyz'" are
the ones that need to happen IMHO.

Thanks.  Line disciplines did not seem suitable for what I
needed, but perhaps can be adapted.

So here's the start of discussion:

1) The IPMI driver needs to run at panic time to modify watchdog
timers and store panic information in the event log.  So no work
queues, no delayed work, and the need for some type of poll
operation on the device.

2) The IPMI driver needs to get messages through even when
the system is very busy.  Since a watchdog runs over the driver,
it needs to be able to get messages through to avoid a system
reset as long as something is pinging the watchdog from userland.

Currently there are mutexes, lock_kernel() calls, and work queues
that cause trouble for these.

There is also a comment that you can't set low_latency and call
tty_flip_buffer_push from IRQ context.  This seems to be due to a
lack of anything in flush_to_ldisc to handle reentrancy, and perhaps
because disc->receive_buf can block, but I couldn't tell easily.

-Corey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Add the ability to layer another driver over the serial driver
    • From: Alan <[email protected]>

• References:
  • [PATCH] Add the ability to layer another driver over the serial driver
    • From: Corey Minyard <[email protected]>
  • Re: [PATCH] Add the ability to layer another driver over the serial driver
    • From: Tilman Schmidt <[email protected]>
  • Re: [PATCH] Add the ability to layer another driver over the serial driver
    • From: Guennadi Liakhovetski <[email protected]>
  • Re: [PATCH] Add the ability to layer another driver over the serial driver
    • From: Corey Minyard <[email protected]>
  • Re: [PATCH] Add the ability to layer another driver over the serial driver
    • From: Alan <[email protected]>

• Prev by Date: [take26-resend1 4/8] kevent: Socket notifications.
• Next by Date: [take26-resend1 0/8] kevent: Generic event handling mechanism.
• Previous by thread: Re: [PATCH] Add the ability to layer another driver over the serial driver
• Next by thread: Re: [PATCH] Add the ability to layer another driver over the serial driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]