Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote:

> On Saturday 09 December 2006 03:36, Randy Dunlap wrote:
> > From: Randy Dunlap <[email protected]>
> > 
> > This driver is an AC97 codec according to its help text.
> > However, if SOUND is disabled, the "select SND_AC97_BUS"
> > still inserts that into the .config file:
> > 
> > #
> > # Sound
> > #
> > # CONFIG_SOUND is not set
> > CONFIG_SND_AC97_BUS=m
> > 
> 
> I consider this abug in kconfig - users of "select" should not know
> full dependency chain for selected symbol.

Seems that I've heard that somewhere else.
so I agree with that part.

> > Even if the config software followed dependency chains on selects,
> > we should try to limit usage of "select" to library-type
> > code that is needed (e.g., CRC functions) instead of bus-type
> > support.
> >
> 
> I do not agree here - the way our directory structure is laid out
> "sound" comes after "Input device support" menuconfig entry.
> Your patch makes user go back and forth in menuconfig, which is
> awkward. I think using select is fine when an option depends on
> something down the stream. If user already had a chance to select
> necessary option then using "depends on" is preferred.

Traversing the menus is not difficult.
(It's easier in xconfig or gconfig than menuconfig IMO,
but not a big deal in any of them.)

Anyway, are you saying that the only fix for this build error
is to fix *config to handle select dependencies?
or could propose another way to handle the build error?

Thanks,
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux