Re: [patch 1/2] agpgart - allow user-populated memory types.

On Fri, 2006-12-08 at 19:24 +0100, Thomas Hellström wrote:
> 
> +       }
> +
> +       if (alloc_size <= PAGE_SIZE) {
> +               new->memory = kmalloc(alloc_size, GFP_KERNEL);
> +       }
> +       if (new->memory == NULL) {
> +               new->memory = vmalloc(alloc_size); 

this bit is more or less evil as well...

1) vmalloc is expensive all the way, higher tlb use etc etc
2) mixing allocation types is just a recipe for disaster
3) if this isn't a frequent operation, kmalloc is fine upto at least 2
pages; I doubt you'll ever want more



-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/2] agpgart - allow user-populated memory types.
    • From: Thomas Hellström <[email protected]>

• References:
  • [patch 1/2] agpgart - allow user-populated memory types.
    • From: Thomas Hellström <[email protected]>

• Prev by Date: RE: [patch] speed up single bio_vec allocation
• Next by Date: Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it
• Previous by thread: Re: [patch 1/2] agpgart - allow user-populated memory types.
• Next by thread: Re: [patch 1/2] agpgart - allow user-populated memory types.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]