On Dec 8 2006 12:43, Josef Sipek wrote:
>> On Dec 8 2006 11:00, Josef Sipek wrote:
>>
>> +void __unionfs_mkdir(void *data)
>> +{
>> + struct sioq_args *args = data;
>> + struct mkdir_args *m = &args->mkdir;
>> +
>> + args->err = vfs_mkdir(m->parent, m->dentry, m->mode);
>> + complete(&args->comp);
>> +}
>>
>> >> The members of m (i.e. m->*) are not modified as for as __unionfs_mknod goes.
>> >> vfs_mknod may only modify the members of m->parent (i.e. m->parent->*)
>> >
>> >Yes they are. The return value is passed through a member of m.
>>
>> Where - where do you see that m->parent, m->dentry or m->mode are modified?
>> (The original submission is above.)
>
>args->err is modified. If args is declared const, gcc complains.
I never said making "args" const, but
rather [-> http://lkml.org/lkml/2006/12/5/210 ] I said:
"Care to make that: const struct mknod_args *m = &args->mknod;?"
-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- References:
- Unionfs: Stackable namespace unification filesystem
- From: "Josef 'Jeff' Sipek" <[email protected]>
- [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: "Josef 'Jeff' Sipek" <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Jan Engelhardt <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Jan Engelhardt <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Jan Engelhardt <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Jan Engelhardt <[email protected]>
- Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- From: Josef Sipek <[email protected]>
- Unionfs: Stackable namespace unification filesystem
- Prev by Date: Re: What was in the x86 merge for .20
- Next by Date: [PATCH] libata: fix oops with sparsemem
- Previous by thread: Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- Next by thread: Re: [PATCH 26/35] Unionfs: Privileged operations workqueue
- Index(es):
 |