Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.

On Fri, 8 Dec 2006, Mariusz Kozlowski wrote:

> > --- a/drivers/media/video/cpia2/cpia2_usb.c
> > +++ b/drivers/media/video/cpia2/cpia2_usb.c
> > @@ -640,6 +640,10 @@ static int submit_urbs(struct camera_dat
> >  		cam->sbuf[i].data =
> >  		    kmalloc(FRAMES_PER_DESC * FRAME_SIZE_PER_DESC, GFP_KERNEL);
> >  		if (!cam->sbuf[i].data) {
> > +			for (--i; i >= 0; i--) {
> > +				kfree(cam->sbuf[i].data);
> > +				cam->sbuf[i].data = NULL;
> > +			}
> >  			return -ENOMEM;
> >  		}
> >  	}
> 
> Just for future. Shorter and more readable version of your for(...) thing:
> 
> 	while (i--) {
> 		...
> 	}
> 

No, that is not equivalent.

You want
	while (i-- >= 0) {
		...
	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.
    • From: Mariusz Kozlowski <[email protected]>

• References:
  • [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.
    • From: Amit Choudhary <[email protected]>
  • Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.
    • From: Mariusz Kozlowski <[email protected]>

• Prev by Date: Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
• Next by Date: cfq performance gap
• Previous by thread: Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.
• Next by thread: Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]