Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()

On Thu, Dec 07, 2006 at 08:06:39PM +0000, David Howells wrote:
> Andrew Morton <[email protected]> wrote:
> 
> > and we can assume (and ensure) that a failing test_and_set_bit() will not
> > write to the affected word at all.
> 
> You may not assume that; and indeed that is not so in the generic
> spinlock-based bitops or ARM pre-v6 or PA-RISC or sparc32 or ...

Incorrect.  pre-v6 ARM bitops for test_and_xxx_bit() all do:

	save and disable irqs
	load value
	test bit
	if not in desired state, alter bit and write it back
	restore irqs

but I don't guarantee that we'll always do that - indeed, post-armv6
bitops always write back even if the bit was in the desired state.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
    • From: Andrew Morton <[email protected]>
  • [PATCH 1/3] WorkStruct: Fix up some PA-RISC work items
    • From: David Howells <[email protected]>
  • [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
    • From: David Howells <[email protected]>
  • Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
    • From: David Howells <[email protected]>

• Prev by Date: Re: [PATCH] free initrds boot option
• Next by Date: Re: single bit errors on files stored on USB-HDDs via USB2/usb_storage
• Previous by thread: Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
• Next by thread: Re: [PATCH 3/3] WorkStruct: Use direct assignment rather than cmpxchg()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]