On Thu, 2006-12-07 at 11:14 -0800, Luben Tuikov wrote:
> It is. If good_bytes=0 then nothing is up to date and uptodate should
> be set to 0.
That's not a correct assumption. Zero transfer commands, like TEST UNIT
READY are perfectly happy to complete successfully with good_bytes == 0.
> Look at my comment before the function call:
> /* A number of bytes were successfully read. ...
>
> I repeat again: it doesn't make sense to call scsi_end_request
> with uptodate=1 and good_bytes=0, since _no bytes are uptodate_.
We can certainly debate that, but it's not appropriate to do it as part
of an unrelated patch.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
