Re: [PATCH] Export current_is_keventd() for libphy

On Thu, 7 Dec 2006 09:57:15 -0800
Andrew Morton <[email protected]> wrote:

> On Thu, 07 Dec 2006 12:05:38 -0500
> Jeff Garzik <[email protected]> wrote:
> 
> > Yes, I merged the code, but looking deeper at phy its clear I missed 
> > some things.
> > 
> > Looking into libphy's workqueue stuff, it has the following sequence:
> > 
> > 	disable interrupts
> > 	schedule_work()
> > 
> > 	... time passes ...
> > 	... workqueue routine is called ...
> > 
> > 	enable interrupts
> > 	handle interrupt
> > 
> > I really have to question if a workqueue was the best choice of 
> > direction for such a sequence.  You don't want to put off handling an 
> > interrupt, with interrupts disabled, for a potentially unbounded amount 
> > of time.
> 
> That'll lock the box on UP, or if the timer fires on the current CPU?

oh. "disable interrupts" == disable_irq(), not local_irq_disable()?

Not so bad ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • [PATCH] Export current_is_keventd() for libphy
    • From: Ben Collins <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andy Fleming <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: David Howells <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Infinite retries reading the partition table
• Next by Date: [PATCH] kbuild: Remove superfluous "!=n" symbol comparisons.
• Previous by thread: Re: [PATCH] Export current_is_keventd() for libphy
• Next by thread: [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]