Re: [PATCH/RFC] CodingStyle updates

[Jan Engelhardt <jengelh@linux01.gwdg.de>]

On Dec 7 2006 00:48, Randy Dunlap wrote:
>+The preferred way to ease multiple indentation levels in a switch
>+statement is to align the "switch" and its subordinate "case" labels in
>+the same column instead of "double-indenting" the "case" labels.  E.g.:
>+
>+	switch (suffix) {
>+	case 'G':
>+	case 'g':
>+		mem <<= 10;
>+	case 'M':
>+	case 'm':
>+		mem << 10;
                ^^^^^^^^^^

Statement has no effect ;-)

>+	case 'K':
>+	case 'k':
>+		mem << 10;

Make that <<=.

>+Use one space around (on each side of) most binary operators, such as
>+any of these:
>+		=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=

And the ternary operator ?:

>+but no space after unary operators:
>+		sizeof  ++  --  &  *  +  -  ~  !  defined

And no space before these unary operators,
++ (postincrement) -- (postdecrement)

What keyword is "defined"? Did you have too much Perl coffee? :)

>+and no space around the '.' unary operator.

Same goes for ->


>+Linux style for comments is the pre-C99 "/* ... */" style.

Aka C89.

>+Don't use C99-style "// ..." comments.
>+
>+The preferred style for long (multi-line) comments is:
>+
>+	/*
>+	 * This is the preferred style for multi-line
>+	 * comments in the Linux kernel source code.
>+	 * Please use it consistently.
>+	 */

Description: Stars to the left with two almost blank (/*, */) lines.



	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/