On Wed, 6 Dec 2006, Linus Torvalds wrote: > > Gcc should do it for us, afaik. I didn't check, but gcc is generally > pretty good at combining logical operations like this, because it's very > common. Sadly, gcc doesn't do it in this case. Still, I'd rather keep the source clean, and hope that the compiler improves eventually, than to make the code uglier. I replaced both of the "test_bit(WORK_STRUCT_PENDING, &work->management)" with "work_pending(work)" in my tree. Now somebody who knows how to trigger this thing should just _test_ it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Export current_is_keventd() for libphy
- From: David Howells <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Linus Torvalds <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- References:
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Linus Torvalds <[email protected]>
- [PATCH] Export current_is_keventd() for libphy
- From: Ben Collins <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: "Maciej W. Rozycki" <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andy Fleming <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Roland Dreier <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: "Maciej W. Rozycki" <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Andrew Morton <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: David Howells <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- From: Linus Torvalds <[email protected]>
- Re: [PATCH] Export current_is_keventd() for libphy
- Prev by Date: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it [try #2]
- Next by Date: Re: Change x86 prefix order
- Previous by thread: Re: [PATCH] Export current_is_keventd() for libphy
- Next by thread: Re: [PATCH] Export current_is_keventd() for libphy
- Index(es):
 |