David Miller wrote:
From: Benjamin Herrenschmidt <[email protected]>
Date: Tue, 05 Dec 2006 16:42:42 +1100
- It's horribly broken in at least two area :
DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!!
and
Where do you handle endianness ? (no need to shout for
that one).
(Or in general, do not use bitfields period ....)
Yes, this is a show stopper, the endianness and
word-size/endian testing should have been done before
submission.
I guess my mistake here was to present it as a patch submission. I
acknowledged in my cover letter that it wasn't feature complete and I'm not
pushing for inclusion just yet. I'm very much aware of the point that when
replacing a subsystem like this, the new code has to be as good as the old
code. In that respect, the patches I posted are lacking in other areas
(isochronous streaming is the big one) that will take more work to fix than
just making it work on big-endian and 64-bit architectures. It's still a work
in progress.
Having said that, I've been working on this for a while now, and I wanted to
announce the effort and open the discussion about replacing the old stack.
Something about "release early, release often"... :) Anyway, I've moved the
portability issues to the top of my list now.
Kristian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
