Re: [PATCH] Add Broadcom PHY support

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

> I believe that this fiber enabling can be done by defining config_init in the phy_driver struct.
> 
> struct phy_driver {
> <snip>
>         /* Called to initialize the PHY,
> 	 * including after a reset */
> 	int (*config_init)(struct phy_device *phydev);
> <snip>
> };

Well... I don't know for sure... thing is, enabling the fiber mode is a
rather platform specific thing. So it's the MAC driver that knows wether
it wants it on a PHY and should call into the driver.

It's difficult to abstract all possible PHY config options tho... some
MACs might want to enable low power, some don't because they have issues
with it, that sort of thing, though.

Not sure what the best solution is at this point... Maybe an ascii
string to pass the PHY driver is the most flexible, though a bit yucky,
or we try to have a list of all the possible configuration options in
phy.h and people just add new ones that they need as they add support
for them...

Sounds grossly like an in-kernel ioctl tho...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/