Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.

> Was the duplication of timings[] deliberate?

It's actually duplicated in all the PIIX/ICH-alike drivers. I could move
it in them all. Jeff - its copied from your piix driver - shall I move
them all ?

 
> diff -puN include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy include/linux/pci_ids.h
> --- a/include/linux/pci_ids.h~pata_it8213-add-new-driver-for-the-it8213-card-tidy
> +++ a/include/linux/pci_ids.h
> @@ -1622,6 +1622,7 @@
>  #define PCI_VENDOR_ID_ITE		0x1283
>  #define PCI_DEVICE_ID_ITE_8211		0x8211
>  #define PCI_DEVICE_ID_ITE_8212		0x8212
> +#define PCI_DEVICE_ID_ITE_8213		0x8213

Sorry about that one - your guess is 100% correct of course
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.
    • From: Jeff Garzik <[email protected]>

• References:
  • [PATCH] pata_it8213: Add new driver for the IT8213 card.
    • From: Alan <[email protected]>
  • Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Incorrect order of last two arguments of ptrace for requests PPC_PTRACE_GETREGS, SETREGS, GETFPREGS, SETFPREGS
• Next by Date: PROBLEM: 2.6.19: OOPS upon boot (not always)
• Previous by thread: Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.
• Next by thread: Re: [PATCH] pata_it8213: Add new driver for the IT8213 card.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]