Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.

Hi Greg,

> > > Provide a function device_move() to move a device to a new parent device. Add
> > > auxilliary functions kobject_move() and sysfs_move_dir().
> > > kobject_move() generates a new uevent of type KOBJ_MOVE, containing the
> > > previous path (DEVPATH_OLD) in addition to the usual values. For this, a new
> > > interface kobject_uevent_env() is created that allows to add further
> > > environmental data to the uevent at the kobject layer.
> > 
> > has this one been tested? I don't get it working. I always get an EINVAL
> > when trying to move the TTY device of a Bluetooth RFCOMM link around.
> 
> I relied on Cornelia to test this.  I think some s390 patches depend on
> this change, right?

my pre-condition is that the TTY device has no parent and then we move
it to a Bluetooth ACL link as child. This however is not working or the
TTY change to use device instead of class_device has broken something.

> > And shouldn't device_move(dev, NULL) re-attach it to the virtual device
> > tree instead of failing?
> 
> Yes, that would be good to have.

Cornelia, please fix this, because otherwise we can't detach a device
from its parent. Storing the current virtual parent looks racy to me.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
    • From: Greg KH <[email protected]>

• References:
  • [PATCH 24/36] Driver core: convert sound core to use struct device
    • From: Greg KH <[email protected]>
  • [PATCH 25/36] Driver core: add dev_archdata to struct device
    • From: Greg KH <[email protected]>
  • [PATCH 26/36] ACPI: Change ACPI to use dev_archdata instead of firmware_data
    • From: Greg KH <[email protected]>
  • [PATCH 27/36] Driver core: Call platform_notify_remove later
    • From: Greg KH <[email protected]>
  • [PATCH 28/36] cpu topology: consider sysfs_create_group return value
    • From: Greg KH <[email protected]>
  • [PATCH 29/36] sysfs: sysfs_write_file() writes zero terminated data
    • From: Greg KH <[email protected]>
  • [PATCH 30/36] driver core: Introduce device_find_child().
    • From: Greg KH <[email protected]>
  • [PATCH 31/36] Driver core: make drivers/base/core.c:setup_parent() static
    • From: Greg KH <[email protected]>
  • [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
    • From: Greg KH <[email protected]>
  • Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
    • From: Marcel Holtmann <[email protected]>
  • Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
    • From: Greg KH <[email protected]>

• Prev by Date: Re: [PATCH 2/10] cxgb3 - main source file
• Next by Date: Re: [PATCH] Add Broadcom PHY support
• Previous by thread: Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
• Next by thread: Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]