RE: [patch] remove redundant iov segment check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote on Monday, December 04, 2006 11:36 AM
> On Mon, 4 Dec 2006 08:26:36 -0800
> "Chen, Kenneth W" <[email protected]> wrote:
> 
> > So it's not possible to call down to generic_file_aio_read/write with invalid
> > iov segment.  Patch proposed to delete these redundant code.
> 
> erp, please don't touch that code.
> 
> The writev deadlock fixes which went into 2.6.17 trashed writev()
> performance and Nick and I are slowly trying to get it back, while fixing
> the has-been-there-forever pagefault-in-write() deadlock.
> 
> This is all proving very hard to do, and we don't need sweeping code
> cleanups happening under our feet ;)
> 
> I'll bring those patches back in next -mm, but not very confidently.


OK, I will wait until that bug settles down and resubmit.  I really don't
see the value of walking the iov multiple times doing the same thing.

I will also dig up the archive to see if I can help in any way.

- Ken
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux