Re: race in sysfs between sysfs_remove_file() and read()/write() #2

On Mon, 4 Dec 2006, Maneesh Soni wrote:

> hmm, I guess Greg has to say the final word. The question is either to fail
> the IO (-ENODEV) or fail the file removal (-EBUSY). If we are not going to
> fail the removal then your patch is the way to go.
> 
> Greg?

Oliver is right that we cannot allow device_remove_file() to fail.  In 
fact we can't even allow it to block until all the existing open file 
references are closed.

Our major questions have to do with the details of the patch itself.  In 
particular, we are worried about possible races with the VFS and the 
handling of the inode's usage count.  Can you examine the patch carefully 
to see if it is okay?

Also, Oliver, it looks like the latest version of your patch makes an 
unnecessary change to sysfs_remove_file().

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: race in sysfs between sysfs_remove_file() and read()/write() #2
    • From: Maneesh Soni <[email protected]>
  • Re: race in sysfs between sysfs_remove_file() and read()/write() #2
    • From: Oliver Neukum <[email protected]>

• References:
  • Re: race in sysfs between sysfs_remove_file() and read()/write() #2
    • From: Maneesh Soni <[email protected]>

• Prev by Date: Re: rtc-ds1307 driver (especially for DS1337, DS1339)
• Next by Date: Re: la la la la ... swappiness
• Previous by thread: Re: race in sysfs between sysfs_remove_file() and read()/write() #2
• Next by thread: Re: race in sysfs between sysfs_remove_file() and read()/write() #2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]