Re: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bela Lubkin wrote:
Andrew Morton wrote:

Sometime, please go through the IPMI code looking for all these
statically-allocated things which are initialised to 0 or NULL and remove
all those intialisations?  They're unneeded, they increase the vmlinux
image size and there are quite a number of them.  Thanks.

Randy Dunlop replied:

I was just about to send that patch.  Here it is,
on top of the series-of-12.
...
-static int bt_debug = BT_DEBUG_OFF;
+static int bt_debug;

Is it wise to significantly degrade code readability to work around a minor
compiler / linker bug?

Is that the only one that is a problem?

I don't think it's a problem.  We *know* that static data areas
are init to 0.  Everything depends on that.  If that didn't work
it would all break.

I could say that it's a nice coincidence that BT_DEBUG_OFF == 0,
but I think that it's more than coincidence.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux