Re: [RFC] timers, pointers to functions and type safety

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Saturday 02 December 2006 19:40, Al Viro wrote:

> RTFPosting.  It might be void *, but it's set via SETUP_TIMER which
> does type checks before casting to void *.
>
> IOW, I don't want _any_ typecasts/container_of necessary in the code.
>
> Sane variant is
>
> void foo_timer(struct net_device *dev)
> {
> 	...
> }
>
> 	struct foo_dev *p = netdev_priv(dev);
> 	SETUP_TIMER(&p->timer, foo_timer, dev);
>
> etc.
>
> With warning generated if foo_timer(dev) would not be type safe.  Without
> typecasts.  Without container_of().  Without any bleeding cruft at all.

You need some more magic macros to access/modify the data field.
Your SETUP_TIMER macro only protects the simple cases, which are easy anyway, 
in this case I prefer the space savings container_of can give us.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/