Re: [RFC] timers, pointers to functions and type safety

[Al Viro <viro@ftp.linux.org.uk>]

On Sat, Dec 02, 2006 at 01:59:30PM +0100, Thomas Gleixner wrote:
> On Fri, 2006-12-01 at 17:21 +0000, Al Viro wrote:
> > Now, there's another question: how do we get there?  Or, at least, from
> > current void (*)(unsigned long) to void (*)(void *)...
> 
> I think the real solution should be 
> 
> 	void (*function)(struct timer_list *timer);
> 
> and hand the timer itself to the callback. Most of the timers are
> embedded into data structures anyway and for the rest we can easily
> build one.

Ewwwwwww....

Let's not.  It means more cruft in callbacks for no good reason.
And more cruft in code setting it up, while we are at it.
 
> > "A fscking huge patch flipping everything at once" is obviously not an
> > answer; too much PITA merging and impossible to review.
> 
> There are ~ 500 files affected and this is in the range of cleanups we
> did recently at the end of the merge window already. I'd volunteer to
> hack this up and keep the patch up to date until the final merge. I have
> done that before and I'm not scared about it. The patches are a couple
> of lines per file and I do not agree that this is impossible to review. 

I'd rather see that as patch series, TYVM.  And no, it won't be a couple
of lines per file with your variant.

Anyway, I'm doing that series in my tree, will post when it's over...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/