Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the following needlessly global functions static:
> - net/netfilter/nf_conntrack_core.c: nf_conntrack_register_cache()
> - net/netfilter/nf_conntrack_core.c: nf_conntrack_unregister_cache()
> - net/netfilter/nf_conntrack_core.c: __nf_conntrack_attach()
> - net/netfilter/nf_conntrack_core.c: set_hashsize()
> - net/netfilter/nf_conntrack_proto_sctp.c: nf_conntrack_proto_sctp_init()
> - net/netfilter/nf_conntrack_proto_sctp.c: nf_conntrack_proto_sctp_fini()
> - make the following needlessly global variables/locks/structs static:
> - net/ipv6/netfilter/nf_conntrack_reasm.c: nf_ct_frag6_secret_interval
> - net/ipv6/netfilter/nf_conntrack_reasm.c: nf_ct_frag6_mem
> - net/netfilter/nf_conntrack_core.c: nf_ct_cache_lock
> - net/netfilter/nf_conntrack_proto_sctp.c: nf_conntrack_protocol_sctp4
> - net/netfilter/nf_conntrack_proto_sctp.c: nf_conntrack_protocol_sctp6
> - #if 0 the following unused global functions:
> - net/ipv6/netfilter/nf_conntrack_reasm.c: nf_ct_frag6_kfree_frags()
> - net/netfilter/nf_conntrack_core.c: nf_conntrack_tuple_taken()
> - net/netfilter/nf_conntrack_core.c: nf_ct_invert_tuplepr()
> - remove the following unused or write-only variables:
> - net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c: nat_module_is_loaded
> - net/ipv6/netfilter/nf_conntrack_reasm.c: nf_ct_frag6_nqueues
> - remove the following unused hooks:
> - net/netfilter/nf_conntrack_core.c: nf_conntrack_destroyed()
> - net/netfilter/nf_conntrack_ftp.c: nf_nat_ftp_hook()
> - remove the following unused EXPORT_SYMBOL's:
> - nf_ct_iterate_cleanup
> - nf_ct_protos
> - nf_ct_l3protos
>
> Please review which of these changes make sense and which might conflict
> with pending patches.
Thanks Adrian. We have a large nf_conntrack merge coming up, which
conflicts with this patch and includes new users of some of these
symbols. Please send your patch again once these changes have
been merged.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
