Re: [patch 5/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_omap_dma.diff

[Pierre Ossman <drzeus-list@drzeus.cx>]

Anderson Briglia wrote:
>
> This patch is needed only for lock/unlock commands. So, it's necessary to
> make MMC omap works when using that feature. It's not a generic patch.
> But I can take off this one from the series and send after (if) the
> series
> is integrated.
>

The patches are marked "[RFC]" which I interpret as that I shouldn't
merge it. Is this incorrect?

>
> frame depends on data->blksz. When we were using data->blksz_bits
> everything was
> ok because we always had a multiple of 16 bits (2 bytes). Once a pwd
> can has a size
> not multiple of 2, the value must be rounded.
> According to MMC OMAP Technical Reference Manual, because of each DMA
> transfer is of
> equal size, it is necessary to have the block size of the transfer be
> a multiple of
> the DMA write access size (which is 2 bytes).
>

This sounds very generic and not something that is specific to the
password command.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/