Re: [patch 3/3] fs: fix cont vs deadlock patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nick Piggin <[email protected]> writes:

> I would be happy if you come up with a quick fix, I'm just trying to
> stamp out a few big bugs in mm. However I did prefer my way of moving
> all the exapand code into generic_cont_expand, out of prepare_write, and
> avoiding holding the target page locked while we're doing all the expand
> work (strictly, you might be able to get away with this, but it is
> fragile and ugly).
>
> AFAIKS, the only reason to use prepare_write is to avoid passing the
> get_block into generic_cont_expand?

IIRC, because generic_cont_expand is designed as really generic. It
can also use for non moronic filesystem.

In the case of reiserfs, it ->prepare_write might be necessary.
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux